Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove module placeholders #4437

Merged
merged 17 commits into from
Dec 13, 2024
Merged

feat: remove module placeholders #4437

merged 17 commits into from
Dec 13, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Dec 4, 2024 •
edited
Loading

Description

  • Remove all placeholder from the module;
  • Add a new option xast.AppendFuncTestCase to the xast.ModifyFunction to add a new test case into a function;
  • Add a new function xast.ModifyStruct to the append values into a struct;

@Pantani Pantani self-assigned this Dec 4, 2024
@github-actions github-actions bot added component:docs Documentation additions or improvements. component:ci CI/CD workflow and automated jobs. component:templates component:configs labels Dec 4, 2024
@Pantani Pantani marked this pull request as draft December 4, 2024 03:49
@Pantani Pantani changed the title feat: remove modules placeholders feat: remove module placeholders Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 90247e8):

https://igntservices-docs--pr4437-feat-remove-module-p-w8ya692n.web.app

(expires Fri, 20 Dec 2024 03:46:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

@Pantani Pantani marked this pull request as ready for review December 12, 2024 07:08
julienrbrt
julienrbrt approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so nice!!!

@julienrbrt julienrbrt merged commit c540c0c into main Dec 13, 2024
45 of 47 checks passed
@julienrbrt julienrbrt deleted the feat/remove-module-placeholders branch December 13, 2024 15:10
@julienrbrt
Copy link
Member

I see there are some left for AutoCLI but this is already a big improvement

@Pantani
Copy link
Collaborator Author

Pantani commented Dec 13, 2024

I see there are some left for AutoCLI but this is already a big improvement

yes, this is a hard one, I'm checking how to do it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

Assignees

@Pantani Pantani

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:docs Documentation additions or improvements. component:packages component:templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pantani @julienrbrt