Fix URL path encoding #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools3 #70 +/- ##
===================================================
+ Coverage 85.21% 85.22% +0.01%
===================================================
Files 16 16
Lines 2015 2017 +2
===================================================
+ Hits 1717 1719 +2
Misses 298 298
Continue to review full report at Codecov.
|
chapulina
approved these changes
May 12, 2020
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Drag Me" feature on Fuel is broken for models with spaces in the name. The root problem is that we are encoding URLs that were already encoded.
This change first decodes a URL, replacing "%XX" characters with their ASCII equivalent. This allows encoding to proceed correctly.
We are preventing resources from containing percent signs in:
Signed-off-by: Nate Koenig [email protected]