Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding angular acceleration to the Link class #1288

Merged
merged 4 commits into from
Jan 13, 2022

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Jan 12, 2022

Signed-off-by: Carlos Agüero [email protected]

🎉 New feature

Summary

This pull request extends the Link class adding the ability to get the angular acceleration.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <[email protected]>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jan 12, 2022
@chapulina chapulina added the physics Involves Ignition Physics label Jan 12, 2022
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #1288 (73afcaf) into ign-gazebo6 (989cd28) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 73afcaf differs from pull request most recent head 296fd61. Consider uploading reports for the commit 296fd61 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo6    #1288   +/-   ##
============================================
  Coverage        62.22%   62.22%           
============================================
  Files              278      278           
  Lines            23122    23126    +4     
============================================
+ Hits             14387    14391    +4     
  Misses            8735     8735           
Impacted Files Coverage Δ
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
src/Link.cc 93.75% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19aba6d...296fd61. Read the comment docs.

Signed-off-by: Ian Chen <[email protected]>
@iche033
Copy link
Contributor

iche033 commented Jan 12, 2022

added test in 73afcaf. Marking this PR as ready

@iche033 iche033 marked this pull request as ready for review January 12, 2022 23:36
@iche033 iche033 requested a review from chapulina as a code owner January 12, 2022 23:36
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iche033
Copy link
Contributor

iche033 commented Jan 13, 2022

Can you just update the tutorial here?

yep updated. da78b81

@iche033
Copy link
Contributor

iche033 commented Jan 13, 2022

The UNIT_SdfGenerator_TEST test failure looks unrelated and ABI report looks good..

@iche033 iche033 merged commit 5b6ef9b into ign-gazebo6 Jan 13, 2022
@iche033 iche033 deleted the world_angular_acceleration branch January 13, 2022 20:16
@chapulina
Copy link
Contributor

The UNIT_SdfGenerator_TEST test failure looks unrelated

I shoved a fix for that into #1286 , because that test was behaving differently for different platforms. It's showing up now since the ign-common 4.5.0 release.

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress physics Involves Ignition Physics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants