-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding angular acceleration to the Link class #1288
Conversation
Signed-off-by: Carlos Agüero <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1288 +/- ##
============================================
Coverage 62.22% 62.22%
============================================
Files 278 278
Lines 23122 23126 +4
============================================
+ Hits 14387 14391 +4
Misses 8735 8735
Continue to review full report at Codecov.
|
Signed-off-by: Ian Chen <[email protected]>
added test in 73afcaf. Marking this PR as ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you just update the tutorial here?
We often forget to
Signed-off-by: Ian Chen <[email protected]>
yep updated. da78b81 |
The |
I shoved a fix for that into #1286 , because that test was behaving differently for different platforms. It's showing up now since the |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1 |
Signed-off-by: Carlos Agüero [email protected]
🎉 New feature
Summary
This pull request extends the
Link
class adding the ability to get the angular acceleration.Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.