-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable more tests on Windows #1286
Conversation
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Although CI result has still some failing tests, did you take as the list of tests to disable the one I had in the original issue? or did you removed the last ones from CI? @chapulina |
I was tackling the ones I saw failing on #1277, let me do the rest now |
Signed-off-by: Louise Poubel <[email protected]>
Ok, I tackled other recent tests in 6ace1df. I think we should wait for an |
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1286 +/- ##
===============================================
+ Coverage 62.21% 62.24% +0.02%
===============================================
Files 276 278 +2
Lines 23016 23135 +119
===============================================
+ Hits 14320 14400 +80
- Misses 8696 8735 +39
Continue to review full report at Codecov.
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1 |
🦟 Bug fix
Summary
This addresses tests that are new on Fortress.
The goal is to have zero failing tests on Windows, this way we know if we're introducing new failures.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸