2 ➡️ 3 #457
Merged
2 ➡️ 3 #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
…ed (#454) The segfault occurs when a model containing a Breadcrumbs system gets unloaded by the level manager. Since systems don't get unloaded, the Breadcrumbs system continues to operate assuming that the model it is associated with is valid. Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #457 +/- ##
===============================================
- Coverage 77.22% 77.21% -0.02%
===============================================
Files 205 205
Lines 11012 11018 +6
===============================================
+ Hits 8504 8507 +3
- Misses 2508 2511 +3
Continue to review full report at Codecov.
|
adlarkin
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-porting
ign-gazebo2toign-gazebo3.The only extra change I needed to do for the port to compile was moving several
ign-physicsincludes fromPhysics.cctoPhysics.hhto compensate for the header inclusion moved up in #443 . TheentityCastfunction needs the features defined before it. CC @adlarkin