Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /image suffix to thermal camera topic name #606

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 3, 2021

Adding /image suffix to make the topic name consistent with a normal camera sensor. This also fixes the camera_info topic name that's generated on the ign-sensors side.

Topic changes:
* /<prefix>/<sensor_name> -> /<prefix>/<sensor_name>/image
* /<prefix>/camera_info -> /<prefix>/<sensor_name>/camera_info

Signed-off-by: Ian Chen [email protected]

@iche033 iche033 requested a review from chapulina as a code owner February 3, 2021 00:14
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Feb 3, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the example need to be updated?

https://github.com/ignitionrobotics/ign-gazebo/blob/d50acebae4b65df18928b0a7a9e62a252be1c608/examples/worlds/thermal_camera.sdf#L104

Update: No, it doesn't - it's using a custom topic.

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #606 (83264b3) into main (6166234) will increase coverage by 0.01%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
+ Coverage   77.38%   77.39%   +0.01%     
==========================================
  Files         213      213              
  Lines       11950    11967      +17     
==========================================
+ Hits         9247     9262      +15     
- Misses       2703     2705       +2     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/World.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Factory.hh 96.05% <ø> (ø)
...e/ignition/gazebo/detail/EntityComponentManager.hh 95.00% <ø> (ø)
include/ignition/gazebo/gui/GuiRunner.hh 100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiSystem.hh 0.00% <ø> (ø)
include/ignition/gazebo/gui/TmpIface.hh 0.00% <ø> (ø)
src/Model.cc 95.58% <ø> (ø)
src/Server.cc 82.80% <ø> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d8762...83264b3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants