4 to 5 #877

ahcorde · 2021-06-23T09:57:32Z

➡️ Forward port

Port 4 to 5

Branch comparison: ign-gazebo5...ign-gazebo4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Signed-off-by: Ashton Larkin <[email protected]>

Signed-off-by: Martiño Crespo <[email protected]> Signed-off-by: Mabel Zhang <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Mabel Zhang <[email protected]>

Signed-off-by: Martiño Crespo <[email protected]>

Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>

…eters (#812) * Add service and GUI to configure physics parameters (step size and real time factor) (#536) Signed-off-by: Maganty Rushyendra <[email protected]> Signed-off-by: Luca Della Vedova <[email protected]> Signed-off-by: ahcorde <[email protected]> Co-authored-by: mrushyendra <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Luca Della Vedova <[email protected]>

* Working on a trigger delay Signed-off-by: Nate Koenig <[email protected]> * Updated tests Signed-off-by: Nate Koenig <[email protected]> * Update documentation Signed-off-by: Nate Koenig <[email protected]> * Fix spelling Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>

Signed-off-by: Louise Poubel <[email protected]>

* tested halt motion feature Signed-off-by: Tomas Lorente <[email protected]> * added flag to turn off movement halting Signed-off-by: Tomas Lorente <[email protected]> * Moved logic into gamelogic Signed-off-by: Tomas Lorente <[email protected]> * docs Signed-off-by: Tomas Lorente <[email protected]> * moved everything into gamelogic Signed-off-by: Tomas Lorente <[email protected]> * test added Signed-off-by: Tomas Lorente <[email protected]> * Fix codecheck Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>

* add conversion for particle scatter ratio field Signed-off-by: Ian Chen <[email protected]> * update integration test Signed-off-by: Ian Chen <[email protected]> * update comment Signed-off-by: Ian Chen <[email protected]>

Signed-off-by: Nate Koenig <[email protected]>

3 to 4 2021 05 20

Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>

Signed-off-by: ahcorde <[email protected]>

) Signed-off-by: ahcorde <[email protected]> Co-authored-by: Michael Carroll <[email protected]>

Signed-off-by: ahcorde <[email protected]>

Signed-off-by: LolaSegura <[email protected]>

Signed-off-by: Ian Chen <[email protected]>

Signed-off-by: Jenn Nguyen <[email protected]>

Signed-off-by: Ashton Larkin <[email protected]>

* add initial draft Signed-off-by: Ian Chen <[email protected]> * fix scatter ratio image path, minor tweaks Signed-off-by: Ian Chen <[email protected]> * formatting Signed-off-by: Ian Chen <[email protected]>

* Fix issue not configuring links added after start Signed-off-by: Jorge Perez <[email protected]> * Add a test checking the fix Signed-off-by: Jorge Perez <[email protected]>

Signed-off-by: Louise Poubel <[email protected]>

* Change the diff_drive_system test to cover min_acceleration and min_velocity limits. Added those limits to the .sdf file. Signed-off-by: LolaSegura <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Franco Cipollone <[email protected]> Co-authored-by: Steve Peters <[email protected]>

Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>

Signed-off-by: Franco Cipollone <[email protected]>

Signed-off-by: Ashton Larkin <[email protected]>

Signed-off-by: Jenn Nguyen <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>

Signed-off-by: Louise Poubel <[email protected]>

3 ➡️ 4

Signed-off-by: Louise Poubel <[email protected]>

chapulina · 2021-06-24T00:15:31Z

There are multiple new test failures that seem to be related to slip (ackermann, diff drive, wheel slip...). Do you know if we need a new ign-physics release to fix those, @scpeters ?

Signed-off-by: Louise Poubel <[email protected]>

scpeters · 2021-06-24T18:00:50Z

There are multiple new test failures that seem to be related to slip (ackermann, diff drive, wheel slip...). Do you know if we need a new ign-physics release to fix those, @scpeters ?

it could be related to the SpeedLimiter changes in #833 and #837 (cc @LolaSegura @francocipollone). I'll take a look this afternoon

chapulina · 2021-06-25T20:41:29Z

I'm not being able to reproduce this locally, I've tried a few different combinations of branches and dependencies.

I re-ran CI for the ign-gazebo5 branch, and it looks like the tests started failing there:

https://github.com/ignitionrobotics/ign-gazebo/runs/2916861022?check_suite_focus=true

  The following tests FAILED:
  	 51 - INTEGRATION_ackermann_steering_system (Failed)
  	 61 - INTEGRATION_breadcrumbs (Failed)
  	 73 - INTEGRATION_diff_drive_system (Failed)
  	107 - INTEGRATION_logical_camera_system (Failed)
  	129 - INTEGRATION_performer_detector (Failed)
  	131 - INTEGRATION_physics_system (Failed)
  	155 - INTEGRATION_wheel_slip (Failed)

The good news is that the failures are not introduced by this PR. The bad news is that we have all these new test failures to deal with.

I suggest we ignore these failures for this PR, and look into them on top of the release branches.

For completeness, I've triggered Jenkins CI for all stable branches:

ign-gazebo5:
ign-gazebo4:
ign-gazebo3:

chapulina · 2021-06-25T22:22:23Z

I've triggered Jenkins CI for all stable branches:

Well, at least the failures are happening only on Edifice.

chapulina

LGTM, I didn't notice any new test failures and the changes look ok.

adlarkin and others added 30 commits April 29, 2021 14:16

Fix documentation for EntityComponentManager::EachNew (#795)

4ee7d57

Signed-off-by: Ashton Larkin <[email protected]>

Contacts visualization (#234)

d3738cb

Signed-off-by: Martiño Crespo <[email protected]>

Backport #763 (#804)

86811f8

Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>

Remove tools/code_check and update codecov (#814)

3d4caa8

Signed-off-by: Louise Poubel <[email protected]>

add conversion for particle scatter ratio field (#791)

b18f6ca

* add conversion for particle scatter ratio field Signed-off-by: Ian Chen <[email protected]> * update integration test Signed-off-by: Ian Chen <[email protected]> * update comment Signed-off-by: Ian Chen <[email protected]>

Merging 3 to 4

20abc25

Signed-off-by: Nate Koenig <[email protected]>

Merge pull request #828 from ignitionrobotics/3-to-4-2021-05-20

6619271

3 to 4 2021 05 20

Prepare for 4.9.0 release (#829)

996684c

Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>

Make halt motiona act like a brake (#830)

be5581f

Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>

4.9.1 prep (#831)

c970caf

Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>

Use moveToHelper from ign-rendering (#825)

0cacbd5

Signed-off-by: ahcorde <[email protected]>

Remove unused headers in video_recoder plugin (#834)

3480302

Signed-off-by: ahcorde <[email protected]>

Removed duplicated code with rendering::sceneFromFirstRenderEngine (#819

65e8b04

) Signed-off-by: ahcorde <[email protected]> Co-authored-by: Michael Carroll <[email protected]>

Cleanup and alphabetize plugin headers (#838)

ee895b8

Signed-off-by: ahcorde <[email protected]>

Using math::SpeedLimiter on the ackermann_steering controller. (#837)

657ca6d

Signed-off-by: LolaSegura <[email protected]>

remove unneeded check (#857)

5694336

Signed-off-by: Ian Chen <[email protected]>

added follow camera offset service (#855)

31676f5

Signed-off-by: Jenn Nguyen <[email protected]>

Fix potentially flaky integration component test case (#848)

5a3b1b8

Signed-off-by: Ashton Larkin <[email protected]>

Add Particle Emitter tutorial (#860)

24d8949

* add initial draft Signed-off-by: Ian Chen <[email protected]> * fix scatter ratio image path, minor tweaks Signed-off-by: Ian Chen <[email protected]> * formatting Signed-off-by: Ian Chen <[email protected]>

Fix WindEffects Plugin bug, not configuring new links (#844)

44f2e92

* Fix issue not configuring links added after start Signed-off-by: Jorge Perez <[email protected]> * Add a test checking the fix Signed-off-by: Jorge Perez <[email protected]>

New example: get an ECM snapshot from an external program (#859)

7c6c70a

Signed-off-by: Louise Poubel <[email protected]>

Depend on ign-rendering 3.5 (#867)

8abfc3b

Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>

Enables confirmation dialog when closing Gazebo. (#850)

fada73c

Signed-off-by: Franco Cipollone <[email protected]>

Refactor RenderUtil::Update with helper functions (#858)

a1ebffa

Signed-off-by: Ashton Larkin <[email protected]>

Set gui camera pose (#863)

483684f

Signed-off-by: Jenn Nguyen <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>

chapulina and others added 3 commits June 22, 2021 15:37

3 -> 4 (#866)

f6a1a84

Signed-off-by: Louise Poubel <[email protected]>

Merge pull request #866 from ignitionrobotics/chapulina/3_to_4

1a7c606

3 ➡️ 4

Merge remote-tracking branch 'origin/ign-gazebo4' into ahcorde/4_to_5

91e3e49

ahcorde requested review from azeey, chapulina and iche033 as code owners June 23, 2021 09:57

github-actions bot added the 🏢 edifice Ignition Edifice label Jun 23, 2021

chapulina added the needs upstream release Blocked by a release of an upstream library label Jun 23, 2021

This was referenced Jun 23, 2021

🎈 11.2.0 gazebosim/sdformat#599

Merged

🎈 5.1.0 gazebosim/gz-gui#241

Merged

chapulina added a commit that referenced this pull request Jun 23, 2021

Depend on SDF 11.2, rendering 5.1 and GUI 5.1 (#877)

7983d2d

Signed-off-by: Louise Poubel <[email protected]>

Depend on SDF 11.2, rendering 5.1 and GUI 5.1. Fix Windows. (#877)

acc627a

Signed-off-by: Louise Poubel <[email protected]>

chapulina force-pushed the ahcorde/4_to_5 branch from 7983d2d to acc627a Compare June 24, 2021 00:17

chapulina removed the needs upstream release Blocked by a release of an upstream library label Jun 24, 2021

chapulina mentioned this pull request Jun 25, 2021

New release for Edifice #885

Closed

chapulina approved these changes Jun 25, 2021

View reviewed changes

chapulina merged commit ee6a29e into ign-gazebo5 Jun 25, 2021

chapulina deleted the ahcorde/4_to_5 branch June 25, 2021 22:24

ibrahiminfinite mentioned this pull request Jun 28, 2021

JointPositionControllerGui Test Failing (Ignition Fortress) #890

Closed

This was referenced Jun 28, 2021

🎈 5.1.0~pre1 #892

Merged

🎈 5.1.0 #896

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

4 to 5 #877

4 to 5 #877

ahcorde commented Jun 23, 2021 •

edited by chapulina

Loading

chapulina commented Jun 24, 2021

scpeters commented Jun 24, 2021

chapulina commented Jun 25, 2021

chapulina commented Jun 25, 2021

chapulina left a comment

4 to 5 #877

4 to 5 #877

Conversation

ahcorde commented Jun 23, 2021 • edited by chapulina Loading

➡️ Forward port

chapulina commented Jun 24, 2021

scpeters commented Jun 24, 2021

chapulina commented Jun 25, 2021

chapulina commented Jun 25, 2021

chapulina left a comment

Choose a reason for hiding this comment

ahcorde commented Jun 23, 2021 •

edited by chapulina

Loading