Exit early if deployments are not allowed #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iche033
requested changes
Apr 23, 2020
azeey
requested changes
Apr 23, 2020
iche033
approved these changes
Apr 28, 2020
azeey
approved these changes
Apr 28, 2020
|
Does the doxygen need to be updated? |
nkoenig
force-pushed
the
breadcrumbs_exit_early
branch
from
3fb0ace to
ea03e8d
Compare
|
Documentation has been updated. |
Signed-off-by: claireyywang <[email protected]> Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: claireyywang <[email protected]> Signed-off-by: Nate Koenig <[email protected]>
* Add and use entityCast helper function * return early for missing features * move minimum map out of entityCast Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Nate Koenig <[email protected]>
* [ign-gazebo2] Update BitBucket links Signed-off-by: Louise Poubel <[email protected]> * [ign-gazebo2] Update BitBucket links Signed-off-by: Louise Poubel <[email protected]> * Apply suggestions from code review Co-authored-by: Marya Belanger <[email protected]> Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Nate Koenig <[email protected]>
…, such as, ign-launch Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
The crash was caused by an access to an invalid address within Qt when trying to access the command line arguments to the application. These are passed as argc and argv to QApplication, but for argc, we were passing a reference to a local. Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
nkoenig
force-pushed
the
breadcrumbs_exit_early
branch
from
ded47ae to
b8ac88b
Compare
added 2 commits
May 6, 2020 15:22
Update documentation
…ign-gazebo into breadcrumbs_exit_early
chapulina
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a topic from creation, and also limits some computation.