Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying topics to record #54

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Aug 26, 2020

Requires: gazebosim/gz-sim#315

Example usage:


    <record>
      <enabled>true</enabled>
      <!-- This path is used by cloudsim, please do not change -->
      <path>/tmp/ign/logs</path>
      <overwrite>true</overwrite>
      <record_topic>/world/.*</record_topic>
    </record>

Useful PR to prevent spamming: gazebosim/gz-transport#164
Signed-off-by: Nate Koenig [email protected]

@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Aug 26, 2020
@chapulina chapulina self-requested a review August 31, 2020 18:53
@nkoenig nkoenig requested a review from iche033 September 1, 2020 15:22
@iche033
Copy link
Contributor

iche033 commented Sep 2, 2020

@osrf-jenkins run tests please

@iche033
Copy link
Contributor

iche033 commented Sep 2, 2020

changes look good. Triggered new jenkins builds as there was an issue with homebrew

@chapulina
Copy link
Contributor

@osrf-jenkins run tests again

@iche033
Copy link
Contributor

iche033 commented Sep 15, 2020

looks like we need a release of ign-gazebo2 first in order for CI to be green

@chapulina chapulina added needs upstream release Blocked by a release of an upstream library and removed needs upstream release Blocked by a release of an upstream library labels Sep 15, 2020
@chapulina
Copy link
Contributor

@osrf-jenkins run tests now that ign-gazebo 2.25.0 is out

@codecov
Copy link

codecov bot commented Sep 19, 2020

Codecov Report

Merging #54 into ign-launch1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-launch1      #54   +/-   ##
============================================
  Coverage        28.15%   28.15%           
============================================
  Files                3        3           
  Lines              721      721           
============================================
  Hits               203      203           
  Misses             518      518           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4600b83...58a25c1. Read the comment docs.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit ef0e172 into ign-launch1 Sep 21, 2020
@chapulina chapulina deleted the record_topics branch September 21, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants