Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial switching physics engines #105

Merged

Conversation

anindex
Copy link
Contributor

@anindex anindex commented Sep 24, 2020

No description provided.

@anindex anindex requested a review from mxgrey as a code owner September 24, 2020 13:45
@chapulina chapulina added documentation Improvements or additions to documentation 🔮 dome Ignition Dome labels Sep 24, 2020
tutorials/04-switching-physics-engines.md Outdated Show resolved Hide resolved
tutorials/04-switching-physics-engines.md Outdated Show resolved Hide resolved
tutorials/04-switching-physics-engines.md Outdated Show resolved Hide resolved
tutorials/04-switching-physics-engines.md Outdated Show resolved Hide resolved
tutorials/04-switching-physics-engines.md Outdated Show resolved Hide resolved
tutorials/04-switching-physics-engines.md Outdated Show resolved Hide resolved
Copy link
Contributor

@claireyywang claireyywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more comment to follow up on. Otherwise LGTM!

tutorials/04-switching-physics-engines.md Outdated Show resolved Hide resolved
Signed-off-by: anindex <[email protected]>
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor comment, otherwise LGTM.

tutorials.md.in Outdated Show resolved Hide resolved
@chapulina chapulina changed the base branch from master to main October 3, 2020 01:33
@chapulina chapulina removed the 🔮 dome Ignition Dome label Oct 3, 2020
@claireyywang claireyywang merged commit 9e0221e into gazebosim:main Oct 8, 2020
claireyywang added a commit that referenced this pull request Jan 7, 2021
* Initial switching physics engines tutorial
* Clearly specify Ignition Gazebo
* Change rendering bash command
* Reduce lines to 80
* Fix numbering tutorials

Co-authored-by: anindex <[email protected]>
Co-authored-by: Claire Wang <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
chapulina added a commit that referenced this pull request Jan 21, 2021
* Initial switching physics engines tutorial
* Clearly specify Ignition Gazebo
* Change rendering bash command
* Reduce lines to 80
* Fix numbering tutorials

Co-authored-by: anindex <[email protected]>
Co-authored-by: Claire Wang <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants