Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped examples to ign-physics3 #107

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Bumped examples to ign-physics3 #107

merged 1 commit into from
Sep 29, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 29, 2020

Signed-off-by: ahcorde [email protected]

@ahcorde ahcorde requested a review from scpeters September 29, 2020 14:51
@ahcorde ahcorde requested a review from mxgrey as a code owner September 29, 2020 14:51
@ahcorde ahcorde self-assigned this Sep 29, 2020
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 29, 2020
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #107 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   83.28%   83.25%   -0.03%     
==========================================
  Files         106      106              
  Lines        3804     3804              
==========================================
- Hits         3168     3167       -1     
- Misses        636      637       +1     
Impacted Files Coverage Δ
dartsim/src/SDFFeatures.cc 66.76% <0.00%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aa60a1...c8ea266. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, we should be running these examples through CI, I ticketed an issue: #109

@chapulina chapulina merged commit ae6d917 into master Sep 29, 2020
@chapulina chapulina deleted the ahcorde/fix/examples branch September 29, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants