Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ign_auto_headers.hh.in #305

Merged

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Nov 8, 2021

🦟 Bug fix

Removes an unused file

Summary

The ign_auto_headers.hh.in is provided by ign-cmake, but for some reason, this package has an old, unused copy in the source code. We can just remove it. Many other ign- packages have this as well, so it can be removed from there when convenient.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

The header template provided by ign-cmake is used instead.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested review from azeey and mxgrey as code owners November 8, 2021 15:14
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Nov 8, 2021
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #305 (ccc2362) into ign-physics2 (c01cbad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-physics2     #305   +/-   ##
=============================================
  Coverage         82.84%   82.84%           
=============================================
  Files               108      108           
  Lines              4243     4243           
=============================================
  Hits               3515     3515           
  Misses              728      728           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c01cbad...ccc2362. Read the comment docs.

@scpeters scpeters merged commit 07b8216 into gazebosim:ign-physics2 Nov 8, 2021
@scpeters scpeters deleted the rm_unused_header_template branch November 8, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants