Bump to SDFormat 10 for Dome

[chapulina]

Several CI PRs will need to be merged before this goes in.

[chapulina]

Windows CI is failing to find DART:

-- Could NOT find DART (missing: DART_DIR)
-- Looking for DART - not found

-- -------------------------------------------

-- BUILD WARNINGS
-- 	Cannot build component [dartsim] - Missing: DART (Components: collision-ode, utils, utils-urdf, CONFIG)
-- END BUILD WARNINGS

Ticketed #87

[codecov]

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   82.46%   82.46%           
=======================================
  Files         106      106           
  Lines        3587     3587           
=======================================
  Hits         2958     2958           
  Misses        629      629           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5056ae8...b64de0f. Read the comment docs.

[chapulina]

The Windows build is failing to find tinyxml2:

  Target "UNIT_tpelib_Link_TEST" links to target "tinyxml2::tinyxml2" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?

I'm not sure if something needs to be changed on ign-physics, on CI infrastructure, or on SDFormat.

Here's the SDFormat PR that bumped it to use tinyxml2 for reference: gazebosim/sdformat#264

[scpeters]

The Windows build is failing to find tinyxml2:

  Target "UNIT_tpelib_Link_TEST" links to target "tinyxml2::tinyxml2" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?

I'm not sure if something needs to be changed on ign-physics, on CI infrastructure, or on SDFormat.

Here's the SDFormat PR that bumped it to use tinyxml2 for reference: osrf/sdformat#264

@mjcarroll do we need to update the sdformat10 cmake config file to include something about tinyxml2? does tinyxml2 need to be linked as PUBLIC? I think it could be PRIVATE instead?

• https://github.com/osrf/sdformat/blob/sdf10/src/CMakeLists.txt#L170-L172

[scpeters]

I created gazebo-tooling/release-tools#247 to help with this, but I don't think it actually fixes the problem

• https://build.osrfoundation.org/job/ign_physics-pr-win/780/

[chapulina]

I think it could be PRIVATE instead?

+1, it's my understanding that tinyxml2 isn't exposed on libSDFormat's public API

[chapulina]

I think it could be PRIVATE instead?

That worked. See gazebosim/sdformat#321 and

[chapulina]

@osrf-jenkins run tests please

[chapulina]

@osrf-jenkins run tests please