Fix DepthGaussianNoise test

[iche033]

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Fixes one of the test Gaussian noise test failures mentioned in #175

Summary

While the difference between data with noise and data without noise should be within 3 sigma, the difference between 2 noisy values should be within 2 * 3 sigma, i.e. full span of the Gaussian noise distribution

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[codecov]

Codecov Report

Merging #271 (897f311) into ign-rendering3 (93539bd) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           ign-rendering3     #271      +/-   ##
==================================================
- Coverage           50.59%   50.58%   -0.01%     
==================================================
  Files                 129      129              
  Lines               11887    11887              
==================================================
- Hits                 6014     6013       -1     
- Misses               5873     5874       +1     

Impacted Files	Coverage Δ
...e/ignition/rendering/base/BaseGaussianNoisePass.hh	96.66% <0.00%> (-3.34%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93539bd...897f311. Read the comment docs.

[adlarkin]

All tests passed, except for Focal on GitHub actions:

/github/workspace/test/integration/render_pass.cc:321: Failure
  The difference between expectedRangeAtMidPoint + noiseMean and mx is 0.032002305984496937, which exceeds noiseTol, where
  expectedRangeAtMidPoint + noiseMean evaluates to 1.4000000000000001,
  mx evaluates to 1.4320023059844971, and
  noiseTol evaluates to 0.029999999329447746.
  [  FAILED  ] GaussianNoise/RenderPassTest.DepthGaussianNoise/ogre2, where GetParam() = "ogre2" (282 ms)

It looks like decreasing noiseTol to 3 * sigma (was originally 4 * sigma) results in a tolerance that is too tight for this check: https://github.com/ignitionrobotics/ign-rendering/blob/695fbd65c397ba6f9eedda03bc51379f506e7e5d/test/integration/render_pass.cc#L321

[iche033]

relaxed tolerance in 897f311, will see if this will make CI happy

[adlarkin]

will see if this will make CI happy

Windows came back red, but I believe that this is due to an issue with one of the Windows CI machines. I have re-triggered windows CI... just waiting in the queue for a spot to open (job 1424 in the queue): https://build.osrfoundation.org/job/ign_rendering-pr-win/

[adlarkin]

Windows is green now 😁