Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move installation instructions from README.md to Installation tutorial #50

Merged
merged 3 commits into from
Sep 30, 2020

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 29, 2020

Consistent with other ignition repos, the installation instructions are in its own tutorial.

Signed-off-by: Ian Chen [email protected]

@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 29, 2020
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   76.32%   76.32%           
=======================================
  Files          23       23           
  Lines        2319     2319           
=======================================
  Hits         1770     1770           
  Misses        549      549           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a81bc...d909836. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have a minor comment about a couple of links.

tutorials/02_install.md Outdated Show resolved Hide resolved
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit e089045 into master Sep 30, 2020
@chapulina chapulina deleted the installation_tutorial branch September 30, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants