Modify to work with new toolchain, fix x509 decode #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several arrays were moved into flash but code was not changed to use pgm_read_byte everywhere needed. Fix, avoiding a crash on SSL cert verification. Also update makefile for the new libs and toolchain.
|
We already put the update in the Arduino core, so no rush. Just wanted to keep you in the loop. |
igrr
reviewed
Jul 6, 2019
|
I'll see what I can do to clean up the issues you've got later this week. Thanks for the quick review! |
Per review request, clean up Makefile to automatically determine if the stdlibs contain versions of memcpy_P/etc. and bracket them with #ifs in the code. Allow users to overrife the mforce32 flag with WITH_PGM_READ_HELPER=1.
earlephilhower
force-pushed
the
fix1
branch
2 times, most recently
from
6356f83 to
8cedb98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several arrays were moved into flash but code was not changed to use
pgm_read_byte everywhere needed. Fix, avoiding a crash on SSL cert
verification.
Also update makefile for the new libs and toolchain.