-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Editor Main Menu #7241
Add Editor Main Menu #7241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Districh-ru , I put few comments here. Could you please check them in your spare time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Districh-ru , I left few more comments here. Could you please check them?
@Districh-ru , thank you so much for this improvement! |
Relates to #6845.
This PR adds Map Editor menu.
![Editor menu](https://private-user-images.githubusercontent.com/113276641/241400314-2158c2a5-b80c-4e09-8c4c-30e587e74ae5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMjczMjgsIm5iZiI6MTczOTAyNzAyOCwicGF0aCI6Ii8xMTMyNzY2NDEvMjQxNDAwMzE0LTIxNThjMmE1LWI4MGMtNGUwOS04YzRjLTMwZTU4N2U3NGFlNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQxNTAzNDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02NWVhMzQyOGQ2MmIwODFhMzVkNGI5ZmUzNzQ0MWZlMDliZTMyN2NjYWM2MWYxNmRjYzhhZjdiNDVhMDJjY2IyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ilTLYwmTw9LO39esHAhTG31aMmq8V03qowXlYwZ5fBY)
fheroes2.2023-05-28.11-12-24-811.1.mp4
Currently it is accessible only in Debug builds by "E" hotkey.
Since the Map Editor functions are WIP this menu currently do not allow create/open maps.