Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Editor Main Menu #7241

Merged
merged 16 commits into from
May 30, 2023
Merged

Add Editor Main Menu #7241

merged 16 commits into from
May 30, 2023

Conversation

Districh-ru
Copy link
Collaborator

@Districh-ru Districh-ru commented May 27, 2023

Relates to #6845.

This PR adds Map Editor menu.
Editor menu

fheroes2.2023-05-28.11-12-24-811.1.mp4

Currently it is accessible only in Debug builds by "E" hotkey.
Since the Map Editor functions are WIP this menu currently do not allow create/open maps.

@Districh-ru Districh-ru added ui UI/GUI related stuff editor Map editor related stuff labels May 27, 2023
@Districh-ru Districh-ru added this to the 1.0.5 milestone May 27, 2023
@Districh-ru Districh-ru self-assigned this May 27, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

src/fheroes2/game/game_editor_mainmenu.cpp Outdated Show resolved Hide resolved
src/fheroes2/game/game_editor_mainmenu.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

src/fheroes2/game/game_editor_mainmenu.cpp Outdated Show resolved Hide resolved
src/fheroes2/game/game_editor_mainmenu.cpp Outdated Show resolved Hide resolved
@Districh-ru Districh-ru added the improvement New feature, request or improvement label May 27, 2023
@Districh-ru Districh-ru marked this pull request as ready for review May 27, 2023 16:44
@Districh-ru Districh-ru requested a review from ihhub May 27, 2023 16:44
@Districh-ru Districh-ru marked this pull request as draft May 27, 2023 16:52
@Districh-ru Districh-ru marked this pull request as ready for review May 27, 2023 16:59
Copy link
Owner

@ihhub ihhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Districh-ru , I put few comments here. Could you please check them in your spare time?

src/fheroes2/game/game_editor_mainmenu.cpp Outdated Show resolved Hide resolved
src/fheroes2/game/game_editor_mainmenu.cpp Outdated Show resolved Hide resolved
src/fheroes2/game/game.h Outdated Show resolved Hide resolved
src/fheroes2/game/game_editor_mainmenu.cpp Outdated Show resolved Hide resolved
src/fheroes2/game/game_editor_mainmenu.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

src/fheroes2/game/game_mainmenu.cpp Show resolved Hide resolved
src/fheroes2/game/game_mainmenu.cpp Show resolved Hide resolved
@Districh-ru Districh-ru requested a review from ihhub May 28, 2023 09:20
Copy link
Owner

@ihhub ihhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Districh-ru , I left few more comments here. Could you please check them?

src/fheroes2/editor/editor_mainmenu.cpp Outdated Show resolved Hide resolved
src/fheroes2/editor/editor_mainmenu.cpp Outdated Show resolved Hide resolved
src/fheroes2/editor/editor_mainmenu.cpp Show resolved Hide resolved
@Districh-ru Districh-ru requested a review from ihhub May 29, 2023 15:32
@ihhub ihhub merged commit f5ab41d into ihhub:master May 30, 2023
@ihhub
Copy link
Owner

ihhub commented May 30, 2023

@Districh-ru , thank you so much for this improvement!

@Districh-ru Districh-ru deleted the editor_main_menu branch May 30, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Map editor related stuff improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants