-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to select instrument brush and brush size in Editor UI #7399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Districh-ru , I left multiple comments here. Could you please check them?
Hi @Districh-ru , I think creating separate functions to return text instead of the proposed container would be even better solution. |
Hi, @ihhub, sure. Initially I was thinking about making such function.. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Districh-ru , I added several comments here. Could you please check them when you have time and see if them make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Districh-ru , I left few more comments in this pull request. My apologies if it takes too much time. Could you please take a look at the comment again and validate if they make sense?
@drevoborod , could you please test these changes? You will need a debug version of the game. Press E in the Main Menu to open the Editor. |
Checked the following:
@Districh-ru , no issues, but:
|
Hi @drevoborod , answering your remarks:
|
Hi @ihhub and @drevoborod, I'll address points 2 and 4 today a little later. |
Hi @drevoborod, the brush size texts are now separated to draw/erase and a/an article in object type descriptions is moved to a new line. |
Checked last changes - for me it looks OK now. |
@Districh-ru , well done! |
This PR relates to #6845 and adds Map Editor UI ability to: