Add functionality to place monsters in the Editor

[ihhub]

relates to #6845

fheroes2.engine.version_.1.0.8.2023-10-01.20-33-07.mp4

There are 2 problems which should be addressed later:

• while changing the terrain we should remove all main objects from a tile
• while using the eraser we should remove all main objects from a tile

Both issues will be addressed in a separate pull request.

[github-actions]

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

[Districh-ru]

Hi, @ihhub, I left a couple comments after a quick check. Could you please check them in your spare time.

Also there is a mouse cursor issue. We may address it in a new PR: if you open the quick info or any dialog (in example quit dialog) the cursor is set to the POINTER after the dialog is closed and returned back to the monster icon after you move it to the nearby tile. (In future we could show a POINTER cursor above the places were the monster can not be placed).

fheroes2.2023-10-01.16-43-14-435.mp4

And a question to discuss - maybe after choosing a monster we should open the Dialog::SelectCount() with the default monster count set by default?

[ihhub]

Hi @Districh-ru , it is better to set monster count separately while you click on the monster. Doing it right after choosing a monster will limit your ability to quickly set them. I know that 0 doesn't mean 0 monsters but we can find a solution later.

[ihhub]

@Districh-ru , I am aware of the cursor issue. This is due to cursor updater class. I am still thinking how to address it properly in a separate PR.

[ihhub]

Hi @zenseii , could you please review the new text dialogs here?

[Districh-ru]

Well done!

In future we should also add random monster placing.

[zenseii]

I left one comment regarding text, @ihhub

[Branikolog]

Hi, @ihhub
I've made a couple of tests. 👍
The only tiny thing I would like to see is turning monster cursor into pointer while hovering over edges of the adventure map.

2023-10-04.11-06-43.mp4

But I suppose it is related to the issue you've discussed above with @Districh-ru . It's not urgent for sure. Everything else works well.

[ihhub]

Hi @Branikolog , I addressed your concern regarding the cursor.

[Branikolog]

Thanks, @ihhub !
There's an issue with positioning of the cursor after right click now:

2023-10-04.16-45-59.mp4

[ihhub]

Hi @Branikolog , this is the same problem which @Districh-ru spotted. This will be addressed in the separate pull request.

[Branikolog]

@ihhub
I mostly concern about the position of the cursor (creature sprite) and the highlighted cell of the map:

Creature sometimes appears on the map really far from the cursor.

The issue spotted by @Districh-ru , relates to showing the pointer cursor instead of creature sprite. Correct me if I'm wrong.

But I want to apologize, the issue I'm talking about is valid for a previous implementation too.

Edit:
Fix for map edges works well.

[Districh-ru]

Creature sometimes appears on the map really far from the cursor.

I also observe this issue: it appears only with disabled software cursor - the upper left corner of the monster sprite is set as the cursor center.
With software cursor turned on this issue does not appear - the center of monster sprite is set as the cursor center.

[ihhub]

Hi @Branikolog , I fixed the issue with the cursor. Please take a look.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Branikolog]

Now cursor works fine for both rendering modes!