Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove random spells from Spell Scroll within Hero dialog and show message about Magic Book duplication #8666

Merged
merged 3 commits into from
May 17, 2024

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented May 17, 2024

relates to #6845

@ihhub ihhub added improvement New feature, request or improvement ui UI/GUI related stuff editor Map editor related stuff labels May 17, 2024
@ihhub ihhub added this to the 1.1.0 milestone May 17, 2024
@ihhub ihhub self-assigned this May 17, 2024
@ihhub ihhub changed the title Remove random spells from Spell Scroll within Hero dialog Remove random spells from Spell Scroll within Hero dialog and show message about Magic Book duplication May 17, 2024
@ihhub ihhub requested a review from Districh-ru May 17, 2024 14:52
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/fheroes2/resource/artifact.cpp Show resolved Hide resolved
Copy link

@ihhub ihhub merged commit 7cc1d29 into master May 17, 2024
21 checks passed
@ihhub ihhub deleted the spell-scroll-hero-dialog branch May 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Map editor related stuff improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants