Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate Random Castle and Town names #8669

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented May 17, 2024

relates to #6845

image

image

@ihhub ihhub added improvement New feature, request or improvement ui UI/GUI related stuff editor Map editor related stuff labels May 17, 2024
@ihhub ihhub added this to the 1.1.0 milestone May 17, 2024
@ihhub ihhub self-assigned this May 17, 2024
@ihhub ihhub requested review from zenseii and Districh-ru May 17, 2024 15:33
@Districh-ru
Copy link
Collaborator

Districh-ru commented May 17, 2024

Then we could also differentiate "Town Army" and "Castle Army". :)

Copy link
Collaborator

@Districh-ru Districh-ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned earlier we can also apply such change to change the text in the lower-right part of this dialog "Castle Army" (line 391) to show "Town Army" when we are editing Town properties.
It can be done in this or in a new PR.

@ihhub
Copy link
Owner Author

ihhub commented May 20, 2024

Let's move it for 1.1.1 release. It is a very minor change and we need to go with translations.

@ihhub ihhub modified the milestones: 1.1.0, 1.1.1 May 20, 2024
@ihhub
Copy link
Owner Author

ihhub commented Jun 3, 2024

Hi @Districh-ru and @zenseii , I am just thinking whether it's worth doing such granular differentiation. What do you think?

@zenseii
Copy link
Collaborator

zenseii commented Jun 3, 2024

@ihhub. I think this works as a nice reminder of whether you're looking at a castle or town.

Edit: Even if there's already the toggle for allowing to build castles, this one is more spelled out and leaves no doubt

@ihhub
Copy link
Owner Author

ihhub commented Jun 3, 2024

As I mentioned earlier we can also apply such change to change the text in the lower-right part of this dialog "Castle Army" (line 391) to show "Town Army" when we are editing Town properties. It can be done in this or in a new PR.

It's done.

Copy link

sonarqubecloud bot commented Jun 3, 2024

@ihhub ihhub merged commit 372c787 into master Jun 3, 2024
21 checks passed
@ihhub ihhub deleted the castle-town-random-name branch June 3, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Map editor related stuff improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants