-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate Random Castle and Town names #8669
Conversation
Then we could also differentiate "Town Army" and "Castle Army". :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned earlier we can also apply such change to change the text in the lower-right part of this dialog "Castle Army" (line 391) to show "Town Army" when we are editing Town properties.
It can be done in this or in a new PR.
Let's move it for 1.1.1 release. It is a very minor change and we need to go with translations. |
Hi @Districh-ru and @zenseii , I am just thinking whether it's worth doing such granular differentiation. What do you think? |
@ihhub. I think this works as a nice reminder of whether you're looking at a castle or town. Edit: Even if there's already the toggle for allowing to build castles, this one is more spelled out and leaves no doubt |
It's done. |
|
relates to #6845