drop python 3.9 support #119
Conversation
hussain-jafari
requested review from
albrja,
collijk,
patricktnast,
rmudambi and
stevebachmeier
as code owners
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| Any manual changes will be lost. | |||
| """ | |||
| from typing import Tuple, Union | |||
| from __future__ import annotations | |||
There was a problem hiding this comment.
We still need these even when dropping 3.9 support? I can never remember when we need this...
There was a problem hiding this comment.
I think its for all the pandas series and indices
There was a problem hiding this comment.
Yeah I thought we wouldn't need this either, but for some reason it's necessary when we try to type hint a variable as a class in the definition of that class itself, e.g.
class Cause:
def init(self, parent_cause: Cause):
self.parent_cause: Cause = parent_cause
There was a problem hiding this comment.
Nevermind I am wrong and don't remember either.
| @@ -21,16 +21,16 @@ def get_base_types(): | |||
| ("name", "str"), | |||
| ("kind", "str"), | |||
| ("gbd_id", ID_TYPES.C_ID), | |||
| ("me_id", f"Union[{ID_TYPES.ME_ID}, Unknown]"), | |||
| ("me_id", f"{ID_TYPES.ME_ID} | Unknown"), | |||
There was a problem hiding this comment.
I wonder if changes like this are going to break the builders. Did you actually test that?
There was a problem hiding this comment.
Yeah I mentioned in the description, but to go into a bit more detail - I built all of the templates, ran isort (the templates don't adhere to linting), and did a git diff.
There was a problem hiding this comment.
I'm gonna go ahead and fix the isort issues actually since I need to add from future import annotations anyway
There was a problem hiding this comment.
Out of scope, but do we have automated test coverage of the builder code? If not, we should create a JIRA ticket to create that.
| @@ -1,3 +1,7 @@ | |||
| **4.1.0 - 11/06/24** | |||
|
|
|||
| - Drop support for Python 3.9 | |||
There was a problem hiding this comment.
Maybe also a line, e.g. "Modernize type hints"
hussain-jafari
force-pushed
the
hjafari/MIC-5489_drop_python_3.9
branch
from
82975c2 to
19e069e
Compare
| @@ -21,16 +21,16 @@ def get_base_types(): | |||
| ("name", "str"), | |||
| ("kind", "str"), | |||
| ("gbd_id", ID_TYPES.C_ID), | |||
| ("me_id", f"Union[{ID_TYPES.ME_ID}, Unknown]"), | |||
| ("me_id", f"{ID_TYPES.ME_ID} | Unknown"), | |||
There was a problem hiding this comment.
Out of scope, but do we have automated test coverage of the builder code? If not, we should create a JIRA ticket to create that.
Category: hotfix JIRA issue: MIC-5526 Changes and notes Update builders so that imports are isort compliant. Testing Built templates and checked git diff.
drop python 3.9 support
Description
Changes and notes
Drop Python 3.9 support.
Use built in list, dicts, and tuples
Use pipe syntax instead of Union or Optional.
Testing
Built templates and compared to current templates.