Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more tests #11

Merged
merged 4 commits into from
Mar 23, 2023
Merged

add more tests #11

merged 4 commits into from
Mar 23, 2023

Conversation

stevebachmeier
Copy link
Contributor

@stevebachmeier stevebachmeier commented Mar 22, 2023 •
edited
Loading

Title: Add more tests

Description

This adds a few more tests. In addition:

  • Rearranges existing __NoiseTypes to the correct order as well as adds missing ones
  • Adds missing noise_functions stubs

Testing

tests pass

rmudambi
rmudambi approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@rmudambi rmudambi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also add a test that rerunning with the same seed results in the same output and that running with a different seed results in a different output.

tests/unit/test_noise_form.py Outdated Show resolved Hide resolved
@stevebachmeier
Copy link
Contributor Author

Looks good. Also add a test that rerunning with the same seed results in the same output and that running with a different seed results in a different output.

@rmudambi Good idea - are you thinking that should be one of the assertions for every unit test on every specific noising function?

@rmudambi
Copy link
Collaborator

rmudambi commented Mar 23, 2023 •
edited
Loading

That seems reasonable to me

@stevebachmeier stevebachmeier merged commit 61c25bd into main Mar 23, 2023
@stevebachmeier stevebachmeier deleted the feature/sbachmei/MIC-3862-add-tests branch March 23, 2023 20:45
stevebachmeier added a commit that referenced this pull request Mar 23, 2023
@stevebachmeier
add more tests (#11)
2dd3e02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmudambi rmudambi rmudambi approved these changes

@albrja albrja Awaiting requested review from albrja albrja is a code owner

@hussain-jafari hussain-jafari Awaiting requested review from hussain-jafari hussain-jafari is a code owner

@mattkappel mattkappel Awaiting requested review from mattkappel

@ramittal ramittal Awaiting requested review from ramittal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevebachmeier @rmudambi