Add descriptions for the first four noise types #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aflaxman
approved these changes
Apr 21, 2023
pletale
approved these changes
Apr 24, 2023
| The first value in this list is the probability that the first digit of the ZIP code will be wrong | ||
| **given that the cell is being considered for this noise type**. | ||
| The second value in the list is this same probability but about the second digit, and so on. | ||
| - [0.04, 0.04, 0.20, 0.36, 0.36] |
There was a problem hiding this comment.
Ok, now that we've changed these (back?), we'd better make sure the values match the actual default values in the code
There was a problem hiding this comment.
I did! They're here:
NathanielBlairStahn
approved these changes
Apr 24, 2023
Co-authored-by: Nathaniel Blair-Stahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add descriptions for the first four noise types
Description
@NathanielBlairStahn interested to get your review here and also compare notes on how you are documenting these.