Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update landing page to remove whitespace around logo and add logo to upper left hand link #130

Merged
merged 9 commits into from
Apr 24, 2023

Conversation

pletale
Copy link
Collaborator

@pletale pletale commented Apr 24, 2023

Title: Updating landing page to remove whitespace around logo and add logo to upper left hand link

Description

  • Category: documentation
  • JIRA issue: none
  • remove extra white space around Pseudopeople logo on first page
  • add a white version of the logo to the upper left hand of the Read the Docs page (as you can see in this PR, I did this by adding an 'html_logo' line to the conf.py file)

Testing

visually checked using make html

@pletale pletale added the documentation Improvements or additions to documentation label Apr 24, 2023
Copy link
Member

@aflaxman aflaxman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to also change the logo_ombre to have less whitespace in this commit?

@pletale
Copy link
Collaborator Author

pletale commented Apr 24, 2023

Did you mean to also change the logo_ombre to have less whitespace in this commit?

I made changes in the docs/source/index.rst file to remove some whitespace, but I can try to crop the PNG file itself to remove more of the whitespace!

@aflaxman
Copy link
Member

aflaxman commented Apr 24, 2023 via email

@pletale pletale requested a review from aflaxman April 24, 2023 17:53
@aflaxman
Copy link
Member

nice. it doesn't help for me to approve again, does it?

@zmbc
Copy link
Collaborator

zmbc commented Apr 24, 2023

@pletale Could you add a screenshot of how this looks, both in the upper left and on the landing page?

@pletale
Copy link
Collaborator Author

pletale commented Apr 24, 2023

image
@zmbc

@pletale
Copy link
Collaborator Author

pletale commented Apr 24, 2023

image @zmbc

I just realized I can probably remove more of the whitespace in the upper left hand corner logo. Going to do that now quickly!

docs/source/conf.py Show resolved Hide resolved
Co-authored-by: Zeb Burke-Conte <[email protected]>
@pletale
Copy link
Collaborator Author

pletale commented Apr 24, 2023

image

Looks great now! Only have to figure out why there is a 'Lint' error now

@zmbc
Copy link
Collaborator

zmbc commented Apr 24, 2023

Only have to figure out why there is a 'Lint' error now

Ah sorry, I think you have to switch the quotes in my suggestion to double quotes instead of single quotes!

@pletale pletale merged commit 81beb82 into develop Apr 24, 2023
@pletale pletale deleted the updating_landing_page branch April 24, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants