Revise explanation of simulation duration #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielBlairStahn
approved these changes
Apr 25, 2023
aflaxman
approved these changes
Apr 25, 2023
| @@ -356,6 +363,7 @@ contractors or self-employed individuals, while a W-2 form is used for employees | |||
| pseudopeople can generate a simulated version of the data collected by W-2 and 1099 forms. | |||
| This is a yearly dataset, where the user-specified year is the **tax year** of the data. | |||
| That is, the data for 2022 will be the result of tax forms filed in early 2023. | |||
| Tax data can be generated for tax years 2019 through 2040 (inclusive). | |||
There was a problem hiding this comment.
I'm definitely going to be confused about tax year vs filing year. But I have confirmed that psp.generate_taxes_w2_and_1099(year=2019) returns some simulated data
There was a problem hiding this comment.
Yes, all the datasets (except SSA) start with 2019. But (unlike some other datasets) there is no tax data returned by psp.generate_taxes_w2_and_1099(year=2041) because that would have to be filed in 2042, which we didn't simulate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise explanation of simulation duration
Description
@NathanielBlairStahn pointed out that this was incorrect the way I had tried to oversimplify it before. The timespans available in different datasets are not exactly the same and need to be noted as such in more places.
Also, thanks to @rmudambi's comment on Slack, I have added some explanation here of the data generated in the final, partial year of the simulation.