Implement targeted omission do_not_respond for census and surveys #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkappel
requested review from
albrja,
hussain-jafari,
ramittal,
rmudambi and
stevebachmeier
as code owners
|
CI breaking atm due to linting. I'll correct in the morning. |
rmudambi
approved these changes
Apr 27, 2023
| pd.Interval(50, 125), | ||
| ] | ||
|
|
||
| DO_NOT_RESPOND_ADDITIVE_PROBABILITY_BY_SEX_AGE: Dict[str, pd.Series] = { |
mattkappel
force-pushed
the
feature/mic-3934-redux-develop
branch
from
9ca9549 to
fefccbb
Compare
albrja
approved these changes
Apr 27, 2023
| @@ -129,7 +129,8 @@ def test_noise_order(mocker, dummy_data, dummy_config_noise_numbers): | |||
|
|
|||
| call_order = [x[0] for x in mock.mock_calls if not x[0].startswith("__")] | |||
| expected_call_order = [ | |||
| "omission", | |||
| # "omit_rows", # Census doesn't use omit_rows | |||
There was a problem hiding this comment.
Can you add a FIXME to update this to another dataset that does have omit_rows?
There was a problem hiding this comment.
You already have a FIXME to do something other than census. Do you have a ticket for that? Otherwise, we ought to create one.
There was a problem hiding this comment.
It didn't look like one existed, so I created MIC-4037.
stevebachmeier
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement targeted omission do_not_respond for census and surveys
Note: a previous version of this PR aimed at a deleted develop branch is here
Description
Changes
Testing
All tests work.