Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add file hashes to doc #170

Merged
merged 4 commits into from
May 8, 2023

Conversation

stevebachmeier
Copy link
Contributor

Title: Add SHA-256 hashes to docs

Description

  • Category: documentation
  • JIRA issue: MIC-4030

After discussion, we decided that the approach to checksums should be
one per zipped package and provided to the user via documentation. This PR
adds those hashes to the docs as well as a very brief description of what
they are an how to use them.

Testing

na

@stevebachmeier stevebachmeier requested review from a team, zmbc and pletale as code owners May 5, 2023 23:58
Copy link
Member

@aflaxman aflaxman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have to remember to update the docs when we update the data... do you have an SOP for data updating that we can put this in?

@rmudambi
Copy link
Collaborator

rmudambi commented May 6, 2023

Now we have to remember to update the docs when we update the data... do you have an SOP for data updating that we can put this in?

We have a plan to write a script to zip and upload new data. Creating the sha would be part of that, and we'll investigate whether we can automate updating the docs as well.

Copy link
Contributor

@NathanielBlairStahn NathanielBlairStahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steve, looks good. It's helpful to have the instructions for generating the checksums documented along with the checksums themselves -- I have never bothered to validate checksums for anything before because I didn't know how to do it and didn't want to bother looking it up.

Is there an easy way within the terminal to verify that the checksums match besides visually inspecting them?

@stevebachmeier
Copy link
Contributor Author

stevebachmeier commented May 6, 2023

Thanks Steve, looks good. It's helpful to have the instructions for generating the checksums documented along with the checksums themselves -- I have never bothered to validate checksums for anything before because I didn't know how to do it and didn't want to bother looking it up.

Is there an easy way within the terminal to verify that the checksums match besides visually inspecting them?

In Linux you can copy/paste the hash into a file and then run a command that checks the hash in the file against the generated one. You can also use diff. Both are kinda hacky but I can add them. I'll need to figure out how to do it for mac and Windows as well.

Comment on lines 84 to 87
If after downloading the file a second time the checksums still do not match,
please open a new `Data access request <https://github.com/ihmeuw/pseudopeople/issues/new?assignees=&labels=&template=data_access_request.yml>`_
using the template under the `Issues tab <https://github.com/ihmeuw/pseudopeople/issues>`_
on pseudopeople's GitHub page.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should just be a "normal" issue -- it's more like a bug report than a data access request IMO.

@aflaxman
Copy link
Member

aflaxman commented May 8, 2023 via email

.. code-block:: console

$ sha256sum PATH/TO/ZIP

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't on my Mac. I have shasum -a 256 PATH/TO/ZIP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, my mac has both. Ok, will update

@stevebachmeier stevebachmeier merged commit e845307 into develop May 8, 2023
@stevebachmeier stevebachmeier deleted the docs/sbachmei/MIC-4030-input-data-checksums branch May 8, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants