-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include household_id cols; update sample data #180
include household_id cols; update sample data #180
Conversation
You have some failing tests. |
…/sbachmei/MIC-4036-4070-include-unnoised-household_id-col
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we have a test that confirms that all datasets have a simulant id and household id column (except I guess the SSA observer won't have household id)?
@rmudambi (what do you mean by SSA won't have household_id? It does) |
Household ID doesn't really make sense for SSA, but I guess it's fine if it's present. Confirm with the RT though. |
Title: Include un-noised household_id column in all datasets
Description
RT requested that the un-noised household_id column is included in all
pseudopeople datasets. This updates the prl sample data to include those
columns and also adds to the schema.
Testing
noised the sample data and confirmed the column is in all datasets.