Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include household_id cols; update sample data #180

Conversation

stevebachmeier
Copy link
Contributor

Title: Include un-noised household_id column in all datasets

Description

RT requested that the un-noised household_id column is included in all
pseudopeople datasets. This updates the prl sample data to include those
columns and also adds to the schema.

Testing

noised the sample data and confirmed the column is in all datasets.

@rmudambi
Copy link
Collaborator

You have some failing tests.

Copy link
Collaborator

@rmudambi rmudambi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have a test that confirms that all datasets have a simulant id and household id column (except I guess the SSA observer won't have household id)?

dfsdf Outdated Show resolved Hide resolved
@stevebachmeier
Copy link
Contributor Author

Shouldn't we have a test that confirms that all datasets have a simulant id and household id column (except I guess the SSA observer won't have household id)?

@rmudambi
I thought about it and it just kinda seemed like overkill to me. But I'll go ahead and add it.

(what do you mean by SSA won't have household_id? It does)

@rmudambi
Copy link
Collaborator

Shouldn't we have a test that confirms that all datasets have a simulant id and household id column (except I guess the SSA observer won't have household id)?

@rmudambi I thought about it and it just kinda seemed like overkill to me. But I'll go ahead and add it.

(what do you mean by SSA won't have household_id? It does)

Household ID doesn't really make sense for SSA, but I guess it's fine if it's present. Confirm with the RT though.

@stevebachmeier stevebachmeier merged commit 4f94992 into develop May 15, 2023
@stevebachmeier stevebachmeier deleted the feature/sbachmei/MIC-4036-4070-include-unnoised-household_id-col branch May 15, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants