Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document requesting no noise with a sentinel value #186

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

zmbc
Copy link
Collaborator

@zmbc zmbc commented May 23, 2023

Document requesting no noise with a sentinel value

Description

  • Category: documentation
  • JIRA issue: none

Adds some documentation of a special value that can be passed to dataset generation functions, to generate datasets with no (configurable) noise. (Configurable noise is all noise except "borrowed SSN.")

Testing

Built locally.

@zmbc zmbc added the documentation Improvements or additions to documentation label May 23, 2023
@zmbc zmbc requested review from a team and pletale as code owners May 23, 2023 16:30
@@ -19,6 +19,9 @@ Due to this fine-grained control, there are a very large number of settings.
**It is not necessary to configure everything.**
pseudopeople includes reasonable default noise settings
and your configuration can override as few or as many of the default values as you like.
You can also pass the special value :code:`pseudopeople.NO_NOISE`, which prevents all configurable noise types
from occurring at all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious what alternatives were considered for the interface, e.g., an option boolean skip_noising or something like that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we directly considered that; it's not a bad idea but it does add an extra "degree of freedom" i.e. someone could set the boolean to False but pass a configuration that specifies no noise, or vice versa.

The other reason I like this API is that in the future, pseudopeople.NO_NOISE could change from being a sentinel value to actually being the full configuration for no noise, and it would be backwards-compatible.

@zmbc
Copy link
Collaborator Author

zmbc commented Jun 8, 2023

I'm merging this; we plan to implement soon. As discussed, there may be another docs PR necessary once we have this implemented (e.g. for the API reference).

@zmbc zmbc merged commit a3874ff into develop Jun 8, 2023
@zmbc zmbc deleted the docs/no-noise-sentinel branch June 8, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants