Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pseudopeople docs to include phonetic noise #209

Merged
merged 6 commits into from
Jul 7, 2023

Conversation

pletale
Copy link
Collaborator

@pletale pletale commented Jul 5, 2023

Title: Update pseudopeople docs to include phonetic noise

Description

  • Category: documentation
  • JIRA issue: SSCI-1402 (RT ticket) and MIC-3879 (engineer ticket)

Testing

visually checked using make_html

@pletale pletale requested review from a team and zmbc as code owners July 5, 2023 22:23
Copy link
Collaborator

@zmbc zmbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I think we can explain the eligible vs actual errors piece a little better here -- I've made some suggestions but feel free to tweak further.

docs/source/noise/column_noise.rst Outdated Show resolved Hide resolved
docs/source/noise/column_noise.rst Outdated Show resolved Hide resolved
@pletale pletale merged commit edbef33 into develop Jul 7, 2023
@pletale pletale deleted the phonetic_noise_function branch July 7, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants