Match date formats to concept model #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmbc
requested review from
a team,
pletale,
albrja,
hussain-jafari,
mattkappel,
ramittal,
rmudambi and
stevebachmeier
as code owners
zmbc
commented
Jul 8, 2023
| for date_column in [COLUMNS.dob.name, COLUMNS.ssa_event_date.name]: | ||
| # Format both the actual column, and the shadow version that will be used | ||
| # to copy from a household member | ||
| for column in [date_column, COPY_HOUSEHOLD_MEMBER_COLS.get(date_column)]: |
There was a problem hiding this comment.
This fixes an unrelated bug I ran into: when a copy-within-household was performed, the column would become partially strings (original values) and partially true datetimes (copied values). This was silently failing in the swap month and day noise function.
aflaxman
approved these changes
Jul 8, 2023
pletale
approved these changes
Jul 11, 2023
rmudambi
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match date formats to concept model
Description
As documented in the concept model, the date formats should be:
This PR brings pseudopeople into alignment with this. Previously, WIC incorrectly used the default, and SSA incorrectly used the default in the date of birth column.
This turned out to be a much more involved change than I realized: previously, date format was incorrectly modeled as an attribute of the column when it is really an attribute of the dataset. Please let me know if I've done this wrong.
Testing
Ran all tests, including with
--runslow. Manually stepped through the swap month and day noise function to ensure it was handling the new date format correctly.