Mic 4208/1040 metadata #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albrja
requested review from
hussain-jafari,
mattkappel,
ramittal,
rmudambi and
stevebachmeier
as code owners
| NOISE_TYPES.make_typos, | ||
| ), | ||
| ) | ||
| spouse_middle_initial: Column = Column( |
There was a problem hiding this comment.
We don't need dependent 1-4 middle initial?
edit: nm, I see it in the docs now
| COLUMNS.dependent_1_last_name, | ||
| COLUMNS.dependent_1_ssn, | ||
| COLUMNS.dependent_2_first_name, | ||
| COLUMNS.dependent_2_last_name, |
There was a problem hiding this comment.
The docs request "type of GQ" columns as well. Do we need household_type here?
There was a problem hiding this comment.
It says for noise functions only. I can verify with RT. Im also not sure about which row types we need since that is not 100% clear to me in the docs.
stevebachmeier
approved these changes
Jul 18, 2023
albrja
force-pushed
the
mic-4208/1040-metada
branch
from
6fd1a8e to
1d0c840
Compare
rmudambi
approved these changes
Jul 18, 2023
albrja
force-pushed
the
mic-4208/1040-metada
branch
from
1d0c840 to
91b9b69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Mic 4208/1040 metadata
Description
Adds metadata for 1040 dataset to schema entities.
-adds additional 1040 columns to schema entities
-adds columns to 1040 dataset
Testing
All tests pass