rename "user_config" arg to "overrides" #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebachmeier
force-pushed
the
feature/sbachmei/MIC-4376-change-user_config-to-overrides
branch
from
f352737 to
ed6bfc7
Compare
stevebachmeier
commented
Aug 10, 2023
| @@ -163,30 +163,30 @@ def test_loading_from_yaml(tmp_path): | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize( | |||
| "user_config, expected", | |||
| "age_differences, expected", | |||
There was a problem hiding this comment.
Changed the name here b/c we were using user_config as both the parameterized age differences lists as well as the name of the dictionary - it worked but was kinda sketchy
stevebachmeier
requested review from
albrja,
hussain-jafari,
mattkappel,
ramittal and
rmudambi
as code owners
albrja
approved these changes
Aug 11, 2023
It kinda-sorta worked. Lots of manual grepping needed but wasn't too bad |
rmudambi
approved these changes
Aug 11, 2023
stevebachmeier
force-pushed
the
feature/sbachmei/MIC-4376-change-user_config-to-overrides
branch
from
2966134 to
beac5b4
Compare
stevebachmeier
deleted the
feature/sbachmei/MIC-4376-change-user_config-to-overrides
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Rename "user_config" arg to "overrides"
Description
RT requested that when calling
psp.get_config(), the user overrideargument should be renamed from
user_configtooverrides.Testing
integration tests pass