-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit introduction page based on doc session feedback #258
Conversation
docs/source/index.rst
Outdated
simulating decennial censuses, surveys, taxes, and other administrative data). | ||
By creating realistic, but simulated, data which includes these attributes, we | ||
can make ER research and development easier for ourselves and others. | ||
Vivarium_ to incorporate real, publicly accessible data about the US population. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this "incorporate" makes it sound kind of sketchy, like it's hiding in the psp output somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vivarium_ to incorporate real, publicly accessible data about the US population. | |
Vivarium_ to imitate real, publicly accessible data about the US population. |
How about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this "incorporate" makes it sound kind of sketchy, like it's hiding in the psp output somewhere.
What's wrong with incorporating "real, publicly accessible data"? That doesn't sound sketchy to me. I don't think we are imitating real, publicly accessible data; I think we are using real data to imitate/simulate the US population.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I do think maybe we should elaborate what we mean by this if we're going to say it. Or maybe we should just say something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re: "sketchy," it just sounds a bit ambiguous what we actually did with that real data, and how it relates to the simulated data. The publicly accessible part should alleviate concerns, but I'm not sure it completely would.
I agree about making this clearer!
Co-authored-by: Zeb Burke-Conte <[email protected]>
Co-authored-by: Zeb Burke-Conte <[email protected]>
docs/source/index.rst
Outdated
simulating decennial censuses, surveys, taxes, and other administrative data). | ||
By creating realistic, but simulated, data which includes these attributes, we | ||
can make ER research and development easier for ourselves and others. | ||
Vivarium_ to incorporate real, publicly accessible data about the US population. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re: "sketchy," it just sounds a bit ambiguous what we actually did with that real data, and how it relates to the simulated data. The publicly accessible part should alleviate concerns, but I'm not sure it completely would.
I agree about making this clearer!
I just tweaked some wording, maybe it's more clear now? Let me know what you think! |
Co-authored-by: Zeb Burke-Conte <[email protected]>
docs/source/index.rst
Outdated
is excited to introduce pseudopeople, the Python package that simplifies Entity Resolution (ER) research and | ||
development. This package generates large-scale, simulated population data according to specifications by the user, | ||
to replicate a range of complexities found in real applications of probabilistic record linkage software. | ||
With sensitive data often required for ER, accessing and testing new methods and software has been a challenge - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With sensitive data often required for ER, accessing and testing new methods and software has been a challenge - | |
With sensitive data often required for ER, accessing and testing new methods and software has been a challenge --- |
This should really be an em dash instead of a hyphen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But see this other suggestion as well.
Co-authored-by: Nathaniel Blair-Stahn <[email protected]>
Co-authored-by: Nathaniel Blair-Stahn <[email protected]>
Co-authored-by: Nathaniel Blair-Stahn <[email protected]>
Title: Edit introduction page based on doc session feedback
Description
Testing