Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mic 4405/add housing type #260

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Mic 4405/add housing type #260

merged 2 commits into from
Aug 22, 2023

Conversation

albrja
Copy link
Contributor

@albrja albrja commented Aug 18, 2023

Mic-4405/add-housing-type

Adds housing type to ACS and Census datasets.

-Adds housing type as output column for ACS and census datasets.
-applies leave blank and choose wrong option noise types to housing type column.

Testing

All tests pass

@@ -1,11 +1,11 @@
state,relationship_to_reference_person,sex,race_ethnicity,tax_form,event_type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does this csv actually come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all our incorrect selection options RT provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does this csv actually come from?

Originally the concept model linked to a .csv in the research repo that listed all the options for "incorrect selection" / "choose the wrong option" noise. I recently removed the reference to this .csv from the concept model because it was redundant and out of date. Now the description of "Incorrect select" noise in the concept model just says,

For those selected, randomly select a new option from the list of all possible options.

and the actual lists of options are provided in the relevant sections of the concept model. So it's up to the engineers to maintain those lists in the code however they see fit.

@albrja albrja force-pushed the mic-4134/remove-dob-age-taxes branch from 4648264 to 09534c7 Compare August 21, 2023 18:54
Base automatically changed from mic-4134/remove-dob-age-taxes to develop August 21, 2023 19:00
@albrja albrja force-pushed the mic-4405/add-housing-type branch from 67a676b to c5cda0b Compare August 22, 2023 18:17
@albrja albrja merged commit b348445 into develop Aug 22, 2023
@albrja albrja deleted the mic-4405/add-housing-type branch August 22, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants