Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement all non-1040 forms #28

Merged
merged 9 commits into from
Apr 4, 2023

Conversation

mattkappel
Copy link
Contributor

Implement all non-1040 forms

Description

  • Category: feature
  • JIRA issue: MIC-3882

Changes

  • Adds ACS, CPS, SSA, and WIC forms interfaces and default configuration
  • Adds ability to pass in DataFrame as source data and pass in a dict as configuration

Testing

Manual testing, ran each noising function against each sample data. Noising succeeded with noising being seen in diffs between source and noising output.

@mattkappel mattkappel changed the base branch from main to develop April 3, 2023 22:57
@mattkappel mattkappel marked this pull request as ready for review April 3, 2023 23:39
Copy link
Collaborator

@rmudambi rmudambi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just revert the one test change I commented on.

src/pseudopeople/utilities.py Outdated Show resolved Hide resolved
tests/unit/test_noise_form.py Outdated Show resolved Hide resolved
@mattkappel mattkappel merged commit 3cd699c into develop Apr 4, 2023
@mattkappel mattkappel deleted the feature/MIC-3882-all-the-forms-minus-1040 branch April 4, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants