Mic 4383/4384/notify if actions fail #334
Conversation
albrja
requested review from
hussain-jafari,
mattkappel,
ramittal,
rmudambi and
stevebachmeier
as code owners
| @@ -50,3 +50,22 @@ jobs: | |||
| - name: Doctest | |||
| run: | | |||
| make doctest -C docs/ | |||
| - name: Send mail | |||
| # Notify when cron job fails | |||
| if: (github.event_name == 'schedule' && failure()) | |||
There was a problem hiding this comment.
Its weird I can't check failure by job.status == 'failure'
There was a problem hiding this comment.
Maybe a more pointed question if anyone knows is I don't understand when I have to use something like ${{ github.job }} instead of just github.event_name
| server_address: smtp.gmail.com | ||
| server_port: 465 | ||
| # user credentials | ||
| username: ${{ secrets.NOTIFY_EMAIL }} |
There was a problem hiding this comment.
I've currently created a new gmail account [email protected] that sends the email.
There was a problem hiding this comment.
I believe I would need to regenerate the password since I didn't save it and would need to do this for all repositories we want it in.
There was a problem hiding this comment.
After discussions today, I will update the secrets email to be the vivarium dev email when we want to implement this in all repositories as that will be a sweeping change.
There was a problem hiding this comment.
Did you update the email to [email protected]? If not, I think you should do that now.
There was a problem hiding this comment.
Yes I have - this currently won't work because I will need to set up the secrets password with the the app password in that email account through gmail.
.github/workflows/build.yml
Outdated
| # email body as text | ||
| body: ${{ github.job }} job in worflow ${{ github.workflow }} of ${{ github.repository }} has ${{ job.status }} | ||
| # comma-separated string, send email to | ||
| to: [email protected] |
There was a problem hiding this comment.
This would need to be replaced with vivarium-dev email and then forward the email to all code owners or we would need to comma separate all code owners emails here.
| server_address: smtp.gmail.com | ||
| server_port: 465 | ||
| # user credentials | ||
| username: ${{ secrets.NOTIFY_EMAIL }} |
There was a problem hiding this comment.
Did you update the email to [email protected]? If not, I think you should do that now.
.github/workflows/deploy.yml
Outdated
| body: ${{ github.job }} job in worflow ${{ github.workflow }} of ${{ github.repository }} has ${{ job.status }} | ||
| # comma-separated string, send email to | ||
| to: [email protected] |
There was a problem hiding this comment.
You missed this email address change.
Mic-4383/4484/notify if actions fail
Sends email notification on actions failures
-Adds functionality to send notifications via email when a cron or deploy workflow actions fails.
Testing
-Made new email to use to send notifications through action
-Recei