Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sbachmei/mic 3923 build docs to readthedocs #34

Merged

Conversation

stevebachmeier
Copy link
Contributor

Title: Build docs on readthedocs

Description

  • Category: documentation
  • JIRA issue: MIC-3923

Added a required config file as well as the webhook to this repo on buildthedocs.

Testing

Docs were built (currently pointed at this branch - need to change it to
main when this merges)

https://pseudopeople.readthedocs.io/en/latest/

.readthedocs.yml Outdated
# Configure the python version and environment construction run before
# docs are built.
python:
version: 3.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this or 3.10?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt it matters as long as docs get built (and we DO support 3.8). This file was just copied from vivarium and I figure if it ain't broke, don't fix it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work with 3.10? If so, we should use it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will try.

.readthedocs.yml Outdated
# Configure the python version and environment construction run before
# docs are built.
python:
version: 3.8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work with 3.10? If so, we should use it.

@ramittal
Copy link

ramittal commented Apr 5, 2023

Nice work, are there any additional steps needed to publish to readthedocs.io? or should we add these steps to deploy.yml?
Would be useful to write the steps you completed on hub to publish docs, so anyone can follow the same steps to publish docs for other repos in future as needed, and avoid investigation.

@ramittal
Copy link

ramittal commented Apr 5, 2023

we should also add install and next steps in getting started.

@stevebachmeier
Copy link
Contributor Author

@ramittal

we should also add install and next steps in getting started.

I agree but that's not this ticket.

Nice work, are there any additional steps needed to publish to readthedocs.io? or should we add these steps to deploy.yml? Would be useful to write the steps you completed on hub to publish docs, so anyone can follow the same steps to publish docs for other repos in future as needed, and avoid investigation.

I don't think there are any steps needed, though I'm not familiar with how this doc-building stuff works at all. It seems to match our other repos so I think it should just work? We do have the docs getting made in our build.yml so I think that working in conjunction with the newly-added webhook will do the magic?

I added the basic steps I took to the ticket itself but it was pretty obvious once logged on. The only tricky part was passing 2fa to log into readthedocs.

@stevebachmeier stevebachmeier merged commit cd178ef into develop Apr 5, 2023
@stevebachmeier stevebachmeier deleted the feature/sbachmei/MIC-3923-build-docs-to-readthedocs branch April 5, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants