Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NORC PVS link as a hotfix #357

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Fix NORC PVS link as a hotfix #357

merged 2 commits into from
Dec 18, 2023

Conversation

pletale
Copy link
Collaborator

@pletale pletale commented Dec 11, 2023

Title: Fix NORC PVS link as a hotfix

Description

  • Category: documentation
  • JIRA issue: SSCI-1515

Testing

  • all tests pass (pytest --runslow)

@pletale pletale added documentation Improvements or additions to documentation hotfix Urgent update to be merged to main instead of develop labels Dec 11, 2023
@pletale pletale requested review from zmbc and a team as code owners December 11, 2023 18:01
zmbc
zmbc approved these changes Dec 11, 2023
View reviewed changes
docs/source/noise/column_noise.rst Outdated Show resolved Hide resolved
aflaxman
aflaxman approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@aflaxman aflaxman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the new link works (and that the old one does not...)

@albrja albrja merged commit 367661d into main Dec 18, 2023
6 checks passed
@albrja albrja deleted the fix_norc_link_hotfix branch December 18, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aflaxman aflaxman aflaxman approved these changes

@zmbc zmbc zmbc approved these changes

@albrja albrja albrja approved these changes

@NathanielBlairStahn NathanielBlairStahn Awaiting requested review from NathanielBlairStahn

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation hotfix Urgent update to be merged to main instead of develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pletale @aflaxman @zmbc @albrja