Add sample data and include in tests #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkappel
requested review from
albrja,
hussain-jafari,
ramittal,
rmudambi and
stevebachmeier
as code owners
stevebachmeier
approved these changes
Apr 6, 2023
| @@ -131,6 +131,7 @@ def miswrite_zipcodes( | |||
| :return: pd.Series of noised zipcodes | |||
| """ | |||
|
|
|||
| column = column.astype(str) | |||
There was a problem hiding this comment.
What are these coming in as now if not strings? I'm concerned if they're coming in as ints again then we will be back to losing preceding 0s (thought I guess the check below would catch that)
There was a problem hiding this comment.
The same dataset has all the zipcodes as 90210, which was being interpreted as an int.
| ("todo", Form.CPS), | ||
| ("todo", Form.WIC), | ||
| ("todo", Form.SSA), | ||
| ("todo", Form.TAX_W2_1099), |
There was a problem hiding this comment.
You knocked out so many TODOs with one fell swoop!
rmudambi
approved these changes
Apr 7, 2023
mattkappel
force-pushed
the
feature/mic-3884-incorporate-sample-dataset
branch
from
0f897c1 to
a92fca3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sample data and include in tests
Description
Changes
Testing
Newly enabled tests complete successfully.