Feature/sbachmei/mic 3957 auto generate default config #39
Conversation
stevebachmeier
force-pushed
the
feature/sbachmei/MIC-3957-auto-generate-default-config
branch
from
a228752 to
7523550
Compare
stevebachmeier
requested review from
albrja,
hussain-jafari,
mattkappel,
ramittal and
rmudambi
as code owners
|
If we generate this at runtime, how will a user know what to override? It would be better if we generate this file programmatically, and commit it to the repo, imho.... |
I'll have to defer to @rmudambi as that's extremely different than what we've been discussing. I will say that folks seemed excited to not have too ever look at this file (to the point of even offering to print it out after generating seemed to get some pushback) @mattkappel Ok, after discussing with Rajan we decided to just keep as is since we don't yet have a requirement for how the user should interact. It is trivial to write it out as you recommend if desired. |
There was a problem hiding this comment.
We do need to have a strategy for testing the configuration generation code creates the correct configuration object.
There was a problem hiding this comment.
Agreed - I thought I'd already written that? Weird.
We should also test that each specific interface call (for each form) calls the expected functions.
There was a problem hiding this comment.
Oh wait, I misunderstood your point. Yeah, I'm not really sure how to test that offhand. Writing tests for that might be more difficult than having just stuck with the initial plan of having a default yaml.
…and comment out unimplemnted stuff instead
…/sbachmei/MIC-3957-auto-generate-default-config
…/sbachmei/MIC-3957-auto-generate-default-config
| assert config_token_noise_level == baseline_level.token_noise_level | ||
| else: | ||
| assert config_token_noise_level == default_token_noise_level | ||
| if noise_type.additional_parameters: |
There was a problem hiding this comment.
I re-worked this to be more inline with how we are doing the previous checks. It also looks at the DEFAULT_NOISE_VALUES now which it previously didn't.
stevebachmeier
deleted the
feature/sbachmei/MIC-3957-auto-generate-default-config
branch
Title: Auto-generate configuration file
Description
This does away with the default_configuration.yaml and instead generates the configuration
file realtime. Some notes:
is_implementedattributes are added to make it easier for the engineers.When something is implemented (eg a new function or a new form), then we can
change that to True and it will be added to the config file.
a "baseline" layer (which is used to instantiate the configuration with the vast
majority of values), a "default" layer which are default values that deviate from
baseline (the obvious example is row omission values which are mostly
0 by default (ie the "baseline" is 0.0) but a few forms have non-zero values, and the
"user" layer.
Testing
All pytests pass