support reading parquet files #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmudambi
requested review from
albrja,
hussain-jafari,
mattkappel,
ramittal and
stevebachmeier
as code owners
mattkappel
approved these changes
Apr 7, 2023
src/pseudopeople/interface.py
Outdated
| elif isinstance(source, Path): | ||
| if source.suffix == ".hdf": | ||
| data = pd.read_hdf(source) | ||
| if not isinstance(data, pd.DataFrame): |
There was a problem hiding this comment.
Should this be moved to after the parquet elif?
There was a problem hiding this comment.
Sure I can move it.
stevebachmeier
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for reading parquet files
Description
Added support for reading parquet files
Added temporary fix to support universal categorical columns
Testing
Ran automated tests
Successfully read both hdf and parquet files with
generate_decennial_census