Omission noise function #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albrja
requested review from
hussain-jafari,
mattkappel,
ramittal,
rmudambi and
stevebachmeier
as code owners
mattkappel
reviewed
Apr 12, 2023
| if isinstance(data, pd.Series): | ||
| not_empty_idx = data.index[(data != "") & (data.notna())] | ||
| else: | ||
| not_empty_idx = data.index |
There was a problem hiding this comment.
Why is this necessary? To handle row-level noise?
There was a problem hiding this comment.
Yes. Allows for the same operation on a dataframe.
mattkappel
approved these changes
Apr 12, 2023
rmudambi
approved these changes
Apr 12, 2023
| pass | ||
|
|
||
| @pytest.fixture(scope="module") | ||
| def dummy_data(): |
There was a problem hiding this comment.
Don't we already have a fixture called dummy_data? Also, we're only using this fixture for the one test, so there's no need for it to have scope="module"
There was a problem hiding this comment.
I think there is a dummy_dataset in test_column noise. We should also be able to use this for duplication noise function but I will remove it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omission noise function
Adds noise function which omits a set of rows in a form.
-adds omit rows noising function and related test suites
Testing
All tests pass successfully.