support only a path to data root directory #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebachmeier
requested review from
albrja,
hussain-jafari,
mattkappel,
ramittal and
rmudambi
as code owners
mattkappel
reviewed
Apr 12, 2023
stevebachmeier
commented
Apr 12, 2023
src/pseudopeople/interface.py
Outdated
| if data_path.suffix == ".hdf": | ||
| data = pd.read_hdf(data_path) | ||
| elif data_path.suffix == ".parquet": | ||
| data = pd.read_parquet(data_path) |
There was a problem hiding this comment.
Yeah I actually had it as a utility function but then realized I only had it here. But then I updated the tests and it's used there as well. I could go either way
mattkappel
reviewed
Apr 12, 2023
…/sbachmei/MIC-3960-use-data-dir
mattkappel
reviewed
Apr 13, 2023
mattkappel
approved these changes
Apr 13, 2023
…/sbachmei/MIC-3960-use-data-dir
rmudambi
approved these changes
Apr 13, 2023
albrja
approved these changes
Apr 13, 2023
| noised_data_different_seed = noising_function(seed=1) | ||
| sample_data_path = list( | ||
| (paths.SAMPLE_DATA_ROOT / data_dir_name).glob(f"{data_dir_name}*") | ||
| )[0] |
There was a problem hiding this comment.
Why are you only grabbing the first file?
There was a problem hiding this comment.
We have control over the sample data and know that there is only one dataset per form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Support only paths to data root directory
Description
This removes support of a user passing in a pd.DataFrame and requires
that the
sourcearg be a path to the data root directory.Testing
Added to the integration pytest that splits the sample data into
two smaller datasets and saves them to tmpdir, then uses tmpdir as
the input.