Albrja/mic 5383/psimulate clock configuration #236
Conversation
albrja
requested review from
collijk,
hussain-jafari,
patricktnast,
rmudambi and
stevebachmeier
as code owners
| end_time = pd.Timestamp(**sim.configuration.time.end.to_dict()) | ||
| step_size = pd.Timedelta(days=sim.configuration.time.step_size) | ||
| num_steps = int(math.ceil((end_time - start_time) / step_size)) | ||
| num_steps = sim.get_number_of_steps(start_time) |
There was a problem hiding this comment.
We shouldn't be providing start time to this method.
There was a problem hiding this comment.
But we have to get it from the Parallel sim context or the backups
There was a problem hiding this comment.
On the line above, it gets the start time from sim.configuration.time.start Isn't that just the model spec start time? Or does this value actually change in the event you're starting from a backup?
CHANGELOG.rst
Outdated
| @@ -1,3 +1,7 @@ | |||
| **2.0.4 - TBD** | |||
There was a problem hiding this comment.
just a reminder to change the date here
| end_time = pd.Timestamp(**sim.configuration.time.end.to_dict()) | ||
| step_size = pd.Timedelta(days=sim.configuration.time.step_size) | ||
| num_steps = int(math.ceil((end_time - start_time) / step_size)) | ||
| num_steps = sim.get_number_of_steps(start_time) |
There was a problem hiding this comment.
On the line above, it gets the start time from sim.configuration.time.start Isn't that just the model spec start time? Or does this value actually change in the event you're starting from a backup?
Albrja/mic 5383/psimulate clock configuration
Updates how vivarium work horse gets number of simulation steps
Changes and notes
-Updates vivarium work horse method to get number of steps from InteractiveContext method
Testing
Successfully ran parallel simulation with custom clock