Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Issue with partial and variable names #133

Closed
mhesselbarth opened this issue Aug 20, 2024 · 0 comments
Closed

🐛 Issue with partial and variable names #133

mhesselbarth opened this issue Aug 20, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mhesselbarth
Copy link
Collaborator

I ran into this strange bug for the gdb engine and calculating partial response function. If two variables have a name overlap, for example, dbh and dbh_cv, there is an issue with variable selection. Instead of only one column for the current v, two columns get returned, namely the current v but also the one with a name overlap.

mboost::predict.mboost(object = self$get_data('fit_best'),
                                                      newdata = dummy_temp, which = v,
                                                      type = type, aggregate = 'sum') 

A hacky solution is to use which = which(names(dummy_temp) == v) instead of which = v. This returns an integer with the column id of the current v

@mhesselbarth mhesselbarth added the bug Something isn't working label Aug 20, 2024
@mhesselbarth mhesselbarth self-assigned this Aug 20, 2024
mhesselbarth added a commit that referenced this issue Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant