Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-strings are only compatible with Python ≥3.6, not 3.5 #168

Closed
zikolach opened this issue Jul 18, 2019 · 6 comments
Closed

F-strings are only compatible with Python ≥3.6, not 3.5 #168

zikolach opened this issue Jul 18, 2019 · 6 comments
Assignees

Comments

@zikolach
Copy link
Contributor

There is a line result.append(f"{indent}'{arg}' (above)") in ixmp/reporting/describe.py which makes ixmp compatible with python 3.6+ only, but currently we did not drop support of neither python 2 or python 3.5.

@khaeru
Copy link
Member

khaeru commented Jul 18, 2019

The documentation states that the reporting features are experimental in ixmp 0.2, and only support Python 3.

@zikolach
Copy link
Contributor Author

The issue is that test suite fails on python 3.5. Is it expected?

@khaeru khaeru changed the title Python 2/3 compatibility issue F-strings are only compatible with Python ≥3.6, not 3.5 Sep 25, 2019
@khaeru
Copy link
Member

khaeru commented Sep 25, 2019

Just a thought: we should check out dependencies and see what is the highest minimum Python version.

@zikolach
Copy link
Contributor Author

Yeah, recently I had hard time figuring out that one of the dependencies was not working because of not having python 3.7. So pip had it installed, just import didn't work.

@khaeru
Copy link
Member

khaeru commented Jan 8, 2020

For reference, NEP 29 from numpy (one of our dependencies) has only Python 3.6+ as of yesterday.

@khaeru
Copy link
Member

khaeru commented Feb 11, 2020

Just a thought: we should check out dependencies and see what is the highest minimum Python version.

As of #263, we require pandas 1.0 which in turn requires Python 3.6.1 (see also pandas-dev/pandas#29212).

@khaeru khaeru closed this as completed Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants