-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pandas 1.0 #263
Support pandas 1.0 #263
Conversation
- Fixes test_reporting_aggregate, TestQuantity.test_assert
Tests appear to pass as of 82561be. |
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
=======================================
Coverage 93.91% 93.92%
=======================================
Files 18 18
Lines 2037 2040 +3
=======================================
+ Hits 1913 1916 +3
Misses 124 124 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @khaeru for fixing it quickly!
Pandas 1.0 is released. This PR makes one adjustment necessary to support pandas 1.0 in ixmp.
Details
The following tests failed:
The following tests trigger a segfault with pandas 1.0:
The common cause seems to be a call to
pd.Series.to_series()
inreporting.utils.AttrSeries.__init__()
; the former was removed in pandas 1.0. When the resulting AttributeError occured inside some new, C- or other compiled code in pandas, it triggered the segfault.Supersedes #261, fixing CI errors on AppVeyor.
PR checklist
Tests added.N/ADocumentation added.N/A