Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save minutes by avoiding duplicate test runs #785

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Jan 25, 2024

This PR removes the trigger for CI runs on pushed to main to avoid duplicate test runs. This avoids duplicate runs.

In order for this to work properly, we should make sure that

  • main can only be reached via PRs
  • PRs need to be up to date with main
  • PRs require several tests to be successful before merging

We might also want to

  • expand the number of tests we require to be successful

All of which can be done via the settings -> branches.

For now, we require the py3.12 and tutorial checks for macos, ubuntu, and windows to be successful.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • [ ] Add or expand tests; coverage checks both ✅ Just changing how often tests are run.
  • [ ] Add, expand, or update documentation. Just changing how often tests are run.
  • [ ] Update release notes. Just changing how often tests are run.

@glatterf42 glatterf42 added the ci Continuous integration label Jan 25, 2024
@glatterf42 glatterf42 added this to the 3.9 milestone Jan 25, 2024
@glatterf42 glatterf42 self-assigned this Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (693f227) 95.2% compared to head (fd45f2f) 95.2%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #785   +/-   ##
=====================================
  Coverage   95.2%   95.2%           
=====================================
  Files         46      46           
  Lines       4335    4335           
=====================================
  Hits        4130    4130           
  Misses       205     205           

@glatterf42 glatterf42 merged commit 7ffee7f into iiasa:main Jan 25, 2024
24 checks passed
@glatterf42 glatterf42 deleted the update/pytest-workflow-triggers branch January 25, 2024 13:15
ywpratama pushed a commit to ywpratama/message_ix that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants